Introduces instance level skip validation option. #644
Conversation
Nitin-Salunke
force-pushed
the
instance_level_skip_validation
branch
from
d1b1628 to
bcf9183
Compare
|
@anilmaurya please have a look at this PR, check if this functionality can be merged. |
README.md
Outdated
| @@ -739,6 +739,13 @@ class Job < ActiveRecord::Base | |||
| end | |||
| ``` | |||
|
|
|||
| Also You can skip the validation at instance level with `some_event_name_without_validation!` method. | |||
| With this you have the flexibility of having validation for all your transitions by default and then skip it wherever required. | |||
| Please not that only update column will be updated as mentioned in the above example. | |||
There was a problem hiding this comment.
| Please not that only update column will be updated as mentioned in the above example. | |
| Please note that only state column will be updated as mentioned in the above example. |
| expect(example.state).to eq('complete') | ||
| end | ||
|
|
||
| it 'shouldn\'t affect the behaviour of existing method after calling _without_validation method' do |
There was a problem hiding this comment.
| it 'shouldn\'t affect the behaviour of existing method after calling _without_validation method' do | |
| it 'shouldn't affect the behaviour of existing method after calling _without_validation! method' do |
There was a problem hiding this comment.
@anilmaurya backslash was intentional to escape the single quote.
README.md
Outdated
| With this you have the flexibility of having validation for all your transitions by default and then skip it wherever required. | ||
| Please not that only update column will be updated as mentioned in the above example. | ||
| <br/> | ||
| <br/> |
README.md
Outdated
| With this you have the flexibility of having validation for all your transitions by default and then skip it wherever required. | ||
| Please not that only update column will be updated as mentioned in the above example. | ||
| <br/> | ||
| <br/> |
|
Hi @Nitin-Salunke , Thank you for your contribution and patience. |
Nitin-Salunke
force-pushed
the
instance_level_skip_validation
branch
from
bcf9183 to
a024ba8
Compare
|
@anilmaurya I have done the changes suggested by you, please have a look. |
Nitin-Salunke
force-pushed
the
instance_level_skip_validation
branch
3 times, most recently
from
ad95c86 to
0404e3e
Compare
|
@Nitin-Salunke PR looks good but travis build is failing for some reason. |
No brainer one is failing with the connection refused error. |
@anilmaurya yes sure. |
Nitin-Salunke
force-pushed
the
instance_level_skip_validation
branch
4 times, most recently
from
6d5b0d7 to
d5dcedb
Compare
Nitin-Salunke
force-pushed
the
instance_level_skip_validation
branch
from
d5dcedb to
305c2be
Compare
|
Code Climate has analyzed commit 305c2be and detected 0 issues on this pull request. View more on Code Climate. |
|
@anilmaurya please merge the PR. |
Codecov Report
@@ Coverage Diff @@
## master #644 +/- ##
==========================================
+ Coverage 95.14% 95.17% +0.03%
==========================================
Files 35 35
Lines 1214 1223 +9
==========================================
+ Hits 1155 1164 +9
Misses 59 59
Continue to review full report at Codecov.
|
|
@Nitin-Salunke Thank you for your contribution. ⚡️ |
|
Released |
We had a specific requirement to skip validations for transitions at the instance level at a few places but at the same time, we wanted the transitions for the model to validated at other places.
The change in this PR just adds a method like
some_event_name_without_validation!which actually skips the validation and set the object state according to the transitions defined.