Use AASM::NO_VALUE as to_state argument default value
#484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teohm
commented
Jul 26, 2017
| @@ -39,18 +39,18 @@ | |||
| it 'should be able to wait into waiting if polite' do | |||
| auth.left_suspend! | |||
| expect(auth.may_left_wait?(:waiting, :please)).to be true | |||
| auth.left_wait!(nil, :please) | |||
There was a problem hiding this comment.
@anilmaurya I noticed nil is explicitly included in argument list when triggering event in the specs. Is this a common in real usage?
This is different from the usage examples written in https://github.com/aasm/aasm/wiki/State-transitions-with-guard-clauses-that-require-arguments
There was a problem hiding this comment.
@teohm Including nil in argument list seems weird to me.
|
Thank you @teohm for contributing , I appreciate your help 🎖 |
|
@anilmaurya By any chance to release this fix some time this month August? 🙏 |
|
Hi @teohm , I am planning to release new version with this fix soon. |
|
That's great! thanks @anilmaurya !! 🎉 |
|
Hi @teohm , just release |
|
Thanks @anilmaurya !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on discussion in #449 (comment)
This PR attempts to fix the root cause of a few issues (#449, #416, #441) with this similar error:
This error happens because AASM incorrectly calls guard method with
one extra argument in certain scenarios. For example:
This happens because in
AASM::Core::Event#_fire(obj, options={}, to_state=nil, *args),the
to_stateargument default nil value is causing ambiguity, i.e. there is no way forAASM to tell whether a caller provides a) one argument with nil value, or b) no argument.
This PR removes this ambiguity by using a symbol as
to_statedefault value.