Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatically set timestamps on state update #418 #427

Closed
wants to merge 1 commit into from
Closed

automatically set timestamps on state update #418 #427

wants to merge 1 commit into from

Conversation

CapCap
Copy link

@CapCap CapCap commented Jan 8, 2017

an attempt at #418

@anilmaurya anilmaurya changed the title automatically set timestamps on state update automatically set timestamps on state update #418 Jan 13, 2017
@reidmorrison
Copy link
Contributor

reidmorrison commented Mar 8, 2017

Rather than building the timestamp capability directly into every persistence layer supported by AASM, could the timestamp mechanism generate a callback under the covers that calls the setter for the column?

This will also keep more advanced logic out of every persistence layer so that they can focus purely on persistence.

@anilmaurya
Copy link
Member

@reidmorrison comment sounds good to me, @CapCap @Drenmi What do you guys think ?

@Drenmi
Copy link

Drenmi commented Mar 9, 2017

Sounds like a sensible approach @reidmorrison. 🙂

@CapCap
Copy link
Author

CapCap commented Mar 24, 2017

@reidmorrison I like it too. Not sure how much time I have to do it though, but will try

@pynixwang
Copy link

what callback should I use to set timestamp column?

@pynixwang
Copy link

before is ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants