[RubyMotion support] Fixing some issues with Proc based guardians and callbacks. #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hod. This may have some impact on debugging for RubyMotion, I would recommend using symbols to define guardians and callbacks whenever possible.
|
I just saw that you have a PR (#316) that adds some logic to the same method. Please tell me if you need me to make a pass on that logic to bring RubyMotion support back after the merge. |
Merged
alto
added a commit
that referenced
this pull request
Feb 9, 2016
[RubyMotion support] Fixing some issues with Proc based guardians and callbacks.
|
I just released version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted an issue due to RubyMotion's Proc implementation.
Proc does not have the method 'parameters' nor 'source_location'.
This was going to be a pain in my ass until I discovered that Proc's 'arity' method had a different behavior in Ruby and RubyMotion.. at my advantage !
I had to sacrify some debugging 'hints' for us RubyMotion developers to achieve the fix, but nothing too hard.