Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No longer creating transaction when not persisting #164

Merged
merged 1 commit into from
Aug 16, 2014
Merged

No longer creating transaction when not persisting #164

merged 1 commit into from
Aug 16, 2014

Conversation

roberthoner
Copy link
Contributor

Fixes #162.

@alto
Copy link
Member

alto commented Aug 16, 2014

Wow, that was quick. Small but meaningful change, tests included, perfect!

Thanks a lot!

alto added a commit that referenced this pull request Aug 16, 2014
@alto
Merge pull request #164 from roberthoner/removing_unnecessary_active_…
a8de03f 
…record_commits

No longer creating transaction when not persisting
@alto alto merged commit a8de03f into aasm:master Aug 16, 2014
@alto
Copy link
Member

alto commented Aug 16, 2014

I just released version 3.3.2 including your changes.

@roberthoner
Copy link
Contributor Author

Excellent! Thanks for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ActiveRecordPersistence] Unnecessary DB transaction on non-persistent events
2 participants
@roberthoner @alto