Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added override blur-up classes #814

Merged
merged 3 commits into from
Jul 17, 2020

Conversation

otmusic
Copy link

@otmusic otmusic commented Jul 14, 2020

No description provided.

blurUpLoadedOriginalClass: 'ls-original-loaded'
};

lazySizesCfg = window.lazySizesConfig || window.lazysizesConfig || {};
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not rely on the global lazySizesConfig. You can simply copy it from lazySizes.cfg + copy it at the start where you declare the variable -> var lazySizesCfg = lazySizes.cfg;

Copy link
Owner

@aFarkas aFarkas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally to my comment. Would you be so nice and also resolve the conflict for me ;-).

Everything else looks very good thank you!

Oleksandr Kharchenko added 2 commits July 16, 2020 09:03
# Conflicts:
#	lazysizes-umd.min.js
#	lazysizes.min.js
#	plugins/blur-up/ls.blur-up.js
#	plugins/blur-up/ls.blur-up.min.js
@otmusic
Copy link
Author

otmusic commented Jul 16, 2020

@aFarkas done

@aFarkas aFarkas merged commit c0e0409 into aFarkas:master Jul 17, 2020
@aFarkas
Copy link
Owner

aFarkas commented Jul 17, 2020

@otmusic Thank you very much.

@otmusic
Copy link
Author

otmusic commented Jul 17, 2020

@aFarkas
You are welcome. Thank you for this really awesome library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants