-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added override blur-up classes #814
Conversation
plugins/blur-up/ls.blur-up.js
Outdated
blurUpLoadedOriginalClass: 'ls-original-loaded' | ||
}; | ||
|
||
lazySizesCfg = window.lazySizesConfig || window.lazysizesConfig || {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not rely on the global lazySizesConfig
. You can simply copy it from lazySizes.cfg
+ copy it at the start where you declare the variable -> var lazySizesCfg = lazySizes.cfg;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally to my comment. Would you be so nice and also resolve the conflict for me ;-).
Everything else looks very good thank you!
# Conflicts: # lazysizes-umd.min.js # lazysizes.min.js # plugins/blur-up/ls.blur-up.js # plugins/blur-up/ls.blur-up.min.js
@aFarkas done |
@otmusic Thank you very much. |
@aFarkas |
No description provided.