Added ability to extend the default html5shiv list of elements #142
Conversation
In order to e.g. run html5shiv over svg elements as well as the default html5 ones without having to know anything about the default list's contents. I've left the code changes deliberately verbose in order to make it clear what's going on, but it could easily be cut down to something more concise (a couple of ternary operators should do it)
|
I like that you've created a helper property for appending elements to the shiv. I don't like that the element list in this commit is missing elements, at least, |
|
I copied the list from the html5shiv Modernizr are using (this was originally a pull request on Modernizr), so that's worrying, but I can update to make the list match the canonical one. This doesn't remove the ability to choose which elements to shiv; the list is only extended if |
|
Well, the current API to add new elements is indeed really bad. The reason for this, is that we don't have a method like I really do understand your problem, but this is not the solution. |
|
Fair enough. The solution I had was just trying to work with the existing API, but if it's gonna be overhauled anyway then that's all to the better. Is an update planned for the near future? |
|
There is currently no roadmap for this. @jonathantneal works on a new version, but this might take some time. I would suggest the following API. html5shiv.addElements('newelement meganewelement');
//or
html5shiv.addElements(['newelement', 'meganewelement']);For the unlikley need remove elements from the list the developer can still use the exposed elements property. What do you think? |
In order to e.g. run html5shiv over svg elements as well as the default html5 ones without having to know anything about the default list's contents.
I've left the code changes deliberately verbose in order to make it clear what's going on, but it could easily be cut down to something more concise (a couple of ternary operators should do it)