Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tokio — this fixes latest compile errors in CI #396

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

imikushin
Copy link
Contributor

This fixes errors that have started popping up in clippy and test CI runs today:

    Checking jolt-core v0.1.0 (/home/runner/work/jolt/jolt/jolt-core)
error[E0599]: no function or associated item named `new` found for struct `tokio::runtime::Runtime` in the current scope
Error:    --> jolt-core/src/host/toolchain.rs:24:27
    |
24  |         let rt = Runtime::new().unwrap();
    |                           ^^^ function or associated item not found in `Runtime`
    |
note: if you're trying to build a new `tokio::runtime::Runtime`, consider using `tokio::runtime::Runtime::from_parts` which returns `tokio::runtime::Runtime`
   --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.38.0/src/runtime/runtime.rs:138:5
    |
138 | /     pub(super) fn from_parts(
139 | |         scheduler: Scheduler,
140 | |         handle: Handle,
141 | |         blocking_pool: BlockingPool,
142 | |     ) -> Runtime {
    | |________________^
    = help: items from traits can only be used if the trait is implemented and in scope
note: `field::binius::BiniusConstructable` defines an item `new`, perhaps you need to implement it
   --> jolt-core/src/field/binius.rs:25:1
    |
25  | pub trait BiniusConstructable {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

For more information about this error, try `rustc --explain E0599`.
error: could not compile `jolt-core` (lib) due to 1 previous error
Error: The process '/home/runner/.cargo/bin/cargo' failed with exit code 101

@imikushin imikushin force-pushed the fix-tokio branch 2 times, most recently from a38b53c to 78cb0e0 Compare June 17, 2024 18:08
tokio `rt-multi-thread` feature is required to be able to use `Runtime::new()`
@imikushin imikushin marked this pull request as ready for review June 17, 2024 18:10
@imikushin
Copy link
Contributor Author

@moodlezoup Noticed the above nastiness showing up in CI.

@mw2000
Copy link
Contributor

mw2000 commented Jun 17, 2024

@moodlezoup I'm facing the same in CI for #385

Copy link
Collaborator

@moodlezoup moodlezoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching this!

@moodlezoup moodlezoup merged commit c0c39e5 into a16z:main Jun 17, 2024
3 checks passed
@imikushin imikushin deleted the fix-tokio branch June 17, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants