This repository has been archived by the owner on Jan 21, 2022. It is now read-only.
Issue 430 Multiplayer Exceptions #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rder to make access to those resources, thread safe.
|
Good work, never had time to fix that myself. Can you have a look at my comments and improve your PR? I will need to test after that. |
Well, my first go was just locking the list but I found that the call to "RegisterEvents" was also non thread safe it was redundant to have 2 locks around. Having a single lock into the constructor was enough. |
added 4 commits
October 23, 2018 19:28
Update with comments of the pull request. Lock access to "LoadedMedias", RegisterEvents and "allInstances" in order to make access to those resources, thread safe.
…001/Vlc.DotNet into Issue430_MultiPlayerExceptions
|
Ok, I have updated the code with all the comments and squash it in the last commit. |
dilandau2001
added a commit
to dilandau2001/Vlc.DotNet
that referenced
this pull request
Oct 24, 2018
Multiplayer Exceptions (ZeBobo5#474)
This was referenced Oct 25, 2018
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out by some users and suffered in my own projects there were some multithreading issues when multiple viewers are playing inside the same application.
I found most of the issues to be regarding access to very specific dictionaries.
These dictionaries were not thread-safe, and updates to them could end in errors like:
NullReferenceException.
Key not present in the dictionary
and memory access exceptions.
In particular access to:
LoadedMedias and RegisterEvents() in VlcMedia classs
and AllInstances inside VlcMediaInstance
I tested those changes inside an applicacion playing 32 streams simultaneously. Without the changes an exception was fired in less than 12 hours. With the changes the application does work longer. (my isses now are more related to libVlc leaking memory,)