Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Japanese translation #12

Merged
merged 2 commits into from
Aug 8, 2022
Merged

Adding Japanese translation #12

merged 2 commits into from
Aug 8, 2022

Conversation

siraken
Copy link
Contributor

@siraken siraken commented Aug 6, 2022

This is my first contribution to an open source project on GitHub.
If something is wrong, please tell me.
I'm familiar with the music well, but I tried to translate it as far as I know.

I want to ask you one thing.
What is "ping-pong scale practice" mean? I couldn't find the appropriate translations in Japanese.

@ZaneH
Copy link
Owner

ZaneH commented Aug 6, 2022

Ping pong means like back and forth

This is great 🙏

@siraken
Copy link
Contributor Author

siraken commented Aug 7, 2022

Thanks! Now I know what "ping pong" means.
So... does that mean going back and forth between scales or repetitive practice?

If there is no suitable expression in Japanese, I will try to add a short explanation on a new line using \n.

And I noticed that "Open settings" was not translated. Is this need to be fixed?

<IconContainer
title='Open settings'
onClick={() => setIsOpen?.(true)}

@ZaneH
Copy link
Owner

ZaneH commented Aug 7, 2022

Thanks! Now I know what "ping pong" means. So... does that mean going back and forth between scales or repetitive practice?

If there is no suitable expression in Japanese, I will try to add a short explanation on a new line using \n.

And I noticed that "Open settings" was not translated. Is this need to be fixed?

<IconContainer
title='Open settings'
onClick={() => setIsOpen?.(true)}

Checkout the video here @ 1:13

It basically lets you practice going "back down" the scale instead of starting back at the beginning of the scale in practice mode.

Good catch on the "Open settings" translation. I just fixed that in master and dev 👍

@siraken
Copy link
Contributor Author

siraken commented Aug 8, 2022

I got it! Now I consider the Japanese translation and will add it.
Thank you for telling me about Ping pong mode and fixing the "Open settings" part 🙏

@ZaneH ZaneH merged commit 3957fb4 into ZaneH:dev Aug 8, 2022
@siraken siraken deleted the dev branch August 9, 2022 01:21
@siraken siraken restored the dev branch August 9, 2022 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants