Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[suggestion] Disable database backup when doing an upgrade #30

Closed
Ezwen opened this issue Jan 9, 2018 · 4 comments
Closed

[suggestion] Disable database backup when doing an upgrade #30

Ezwen opened this issue Jan 9, 2018 · 4 comments

Comments

@Ezwen
Copy link

Ezwen commented Jan 9, 2018

Each time I upgrade synapse on Yunohost, it takes a huge amount of time because of the database backup it makes just before the upgrade attempt.

However, as far as I know, upgrading synapse never alters the database, it only alters configuration files and synapse installation itself, right?

Therefore, I would suggest to find a way to disable entirely the database backup during the pre-upgrade backup, if that possible.
@Josue-T
Copy link

Josue-T commented Jan 9, 2018

I understand your point of view but I had many problem with the upgrade of some user how as broken his instance, so it's the reason because I had implemented the backup before the upgrade.

I propose to make app setting that you can set to disable the backup. But after if the upgrade fail and the app is broken it will be at your own risk.

@Ezwen
Copy link
Author

Ezwen commented Jan 9, 2018

An option would be OK for me :)

@Josue-T
Copy link

Josue-T commented Jan 14, 2018

I have pushed a release witch implement this, so I close the issue if it's ok for you.
The settings to set for that is written in the readme.

@Josue-T Josue-T closed this as completed Jan 14, 2018
@Ezwen
Copy link
Author

Ezwen commented Jan 14, 2018

that's really nice of you, thanks! I'll give it a try!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ezwen @Josue-T