Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace banners with a new design #5502

Merged
merged 2 commits into from
Sep 6, 2016
Merged

Conversation

atimmer
Copy link
Contributor

@atimmer atimmer commented Sep 6, 2016

Summary

This PR can be summarized in the following changelog entry:
Replaced banners with a new design

Relevant technical choices:

n/a

Test instructions

This PR can be tested by following these steps:

  • Look at the settings pages and observe the new banners.

Fixes #5458

@yoastbot
Copy link
Collaborator

yoastbot commented Sep 6, 2016

Thanks for your contribution! For your convenience and to give some guidelines to the one who is going to review your pull request, here's a checklist:

  • The pull request has a clear description which summarizes the purpose and the technical changes made.
  • Unit tests exist which cover the modified or added code.
  • The tests pass.
  • The pull request doesn't add duplicate code.
  • The pull request follows single responsibility principle for all functions, methods and objects.
  • Functions, methods, objects and variables added by this pull request have descriptive names that make it easy and intuitive to understand what they are about.
  • Documentation is descriptive.
  • The code in this pull request doesn't introduce any security issues. For reference: OWASP top ten vulnerabilities.

@terw-dan
Copy link
Member

terw-dan commented Sep 6, 2016

Acceptance 👍

@terw-dan terw-dan merged commit e86d927 into release/3.5 Sep 6, 2016
@atimmer atimmer deleted the stories/at/replace-banners branch September 6, 2016 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants