537 refactor microcaching the api endpoints into using cache decorators #21879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thijsoo
added
the
changelog: non-user-facing
Pull Request Test Coverage Report for Build 9c7ab956e19bbe25f9d4a0b686fe9c3e9e761ad9Details
💛 - Coveralls |
…tor-microcaching-the-api-endpoints-into-using-cache-decorators # Conflicts: # src/dashboard/infrastructure/score-results/readability-score-results/readability-score-results-collector.php # src/dashboard/infrastructure/score-results/seo-score-results/seo-score-results-collector.php
leonidasmi
reviewed
Dec 10, 2024
|
|
||
| return $results; | ||
| } | ||
| $results = $this->readability_score_results_collector->get_score_results( $score_groups, $content_type, $term_id, $is_troubleshooting ); |
There was a problem hiding this comment.
I would like an empty line above, but that's maybe just me?
There was a problem hiding this comment.
Same for the other cached collector
| if ( $is_troubleshooting !== true ) { | ||
| \set_transient( $transient_name, WPSEO_Utils::format_json_encode( $current_scores ), \MINUTE_IN_SECONDS ); | ||
| } | ||
|
|
||
| $results['scores'] = $current_scores; | ||
| $results['cache_used'] = false; |
There was a problem hiding this comment.
I think that the collector should be agnostic of anything cache related, so I think it's the cached collectors' responsibility to set $results['cache_used'] = false;
| ?bool $is_troubleshooting | ||
| ) { | ||
| $content_type_name = $content_type->get_name(); | ||
| $transient_name = Readability_Score_Results_Collector::READABILITY_SCORES_TRANSIENT . '_' . $content_type_name . ( ( $term_id === null ) ? '' : '_' . $term_id ); |
There was a problem hiding this comment.
The READABILITY_SCORES_TRANSIENT constant should be set in this class, instead of the cache-agnostic collector, I think.
leonidasmi
deleted the
537-refactor-microcaching-the-api-endpoints-into-using-cache-decorators
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.Documentation
Quality assurance
Innovation
innovationlabel.Fixes #