Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version increase #21828

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Version increase #21828

merged 1 commit into from
Nov 22, 2024

Conversation

d-claassen
Copy link
Contributor

@d-claassen d-claassen commented Nov 15, 2024

Important

Do not rebase this PR. The "Version increase" commit 6c11d5d is the exact version that has been published to NPM. Orphaning this commit will make it impossible to properly determine changes since the published version.

Context

  • Release our Yoast UI library:
  • @yoast/ui-library:4.1.0

Summary

This PR can be summarized in the following changelog entry:

  • Release new package versions.

Relevant technical choices:

  • n/a

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • n/a: only manifest updates. all actual code changes have already been made.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

  • n/a

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

  • n/a

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

- @yoast/ui-library:4.1.0
@d-claassen d-claassen requested a review from a team as a code owner November 15, 2024 14:38
@coveralls
Copy link

Pull Request Test Coverage Report for Build 95eaa8043f293a4e11a33a7ae9368f608a87a8c4

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 57.4%

Totals Coverage Status
Change from base Build e64062e063c5647c49686aa9ee507e1271850151: 0.0%
Covered Lines: 13347
Relevant Lines: 22887

💛 - Coveralls

@d-claassen d-claassen merged commit c8ccdfb into trunk Nov 22, 2024
16 checks passed
@d-claassen d-claassen deleted the d-claassen/ui-library-4.1.0 branch November 22, 2024 09:16
@mhkuu mhkuu added this to the 24.1 milestone Nov 22, 2024
@mhkuu mhkuu added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants