Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P2 1369 revert prominent from free #17500

Merged
merged 1 commit into from
Oct 8, 2021

Conversation

increddibelly
Copy link
Contributor

Context

  • PR 17494 was made to free while we were moving cleanup code from Premium to Free. Meanwhile, it was decided to keep these cleanup actions in Premium, so the move was abandoned and PR 17494 needs to be ported to Premium.

Summary

This PR can be summarized in the following changelog entry:

  • N/A

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects other environments and needs to be tested there.

Documentation

  • I have written documentation for this change.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.

Fixes #

@increddibelly increddibelly added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Oct 8, 2021
@increddibelly increddibelly added this to the 17.4 milestone Oct 8, 2021
@leonidasmi leonidasmi changed the base branch from trunk to release/17.4 October 8, 2021 07:53
@increddibelly increddibelly merged commit 16ab7e7 into release/17.4 Oct 8, 2021
@increddibelly increddibelly deleted the P2-1369-revert-prominent-from-free branch October 8, 2021 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants