Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch Theme Function bug #6665

Closed
KonVei82 opened this issue Jan 6, 2025 · 4 comments
Closed

Switch Theme Function bug #6665

KonVei82 opened this issue Jan 6, 2025 · 4 comments
Assignees
@si458
Labels
bug

Comments

@KonVei82
Copy link

KonVei82 commented Jan 6, 2025

Describe the bug
After switching to siteStyle": 3 and playing with the new Switch Theme function i somehow managed to bug out the theme. Unfortunately i do not recall which theme i picked last while testing but it seems one of the the available bootstrap themes has the potential to get stuck and you are unable to switch out of it since pressing the Switch Theme button does not produce any pop up to allow you and select a different theme at that point.

Screenshots
image
image

Server Software (please complete the following information):

  • OS: Ubuntu
  • Virtualization: Docker
  • Network: WAN
  • Version: 1.1.37

Your config.json file

{
  "settings": {
    "_user": "**********",
    "cert": "*****************",
    "WANonly": true,
    "port": 444,
    "aliasPort": 443,
    "redirPort": 0,
    "AgentPong": 60,
    "trustedProxy": "172.18.0.2",
    "tlsOffload": "172.18.0.2",
    "sessionTime": 120,
    "WebRTC": "false",
    "amtManager": "false",
    "mpsport":0
  },
  "domains": {
        "": {
        "_title": "MyServer",
    "_title2": "Servername",
    "siteStyle": 3,
    "userSessionIdleTimeout": 60,
    "hide": 5,
    "nightMode": 1,
    "minify": false,
    "newAccounts": false,
    "certUrl": "172.18.0.2:443/"
     }
   }
 }
@KonVei82 KonVei82 added the bug label Jan 6, 2025
@si458
Copy link
Collaborator

si458 commented Jan 6, 2025

ok ive replicated the bug!
you pick a theme, save it, then change it back to default and it goofs up,
it tries to load the theme default rather than IF its default just unload the current theme

also discovered the themes arent loading the fonts correctly either due to Content-Security-Policy!

@si458 si458 self-assigned this Jan 6, 2025
si458 added a commit that referenced this issue Jan 6, 2025
@si458
fix theme switch to default bug and include google fonts in csp #6665
def6207 
Signed-off-by: si458 <simonsmith5521@gmail.com>
@si458
Copy link
Collaborator

si458 commented Jan 6, 2025 •
edited
Loading

all fixed for you 👍

basically it was trying to load the bootstrap theme default which is in a totally different place as it shouldnt be customised!

a work around is to simple copy public/styles/bootstrap.min.css to public/styles/themes/default/bootstrap.min.css
you will have to create the folder default as it doesnt exist

the commit def6207 WILL rename the theme files from bootstrap.min.css to bootstrap-min.css to stay in line with our anything with -min at the end is a minifed file
and also uses the default bootstrap theme which is a level up .. from themes

@si458 si458 closed this as completed Jan 6, 2025
@si458
Copy link
Collaborator

si458 commented Jan 10, 2025

1.1.38 released with the fix 👍

@KonVei82
Copy link
Author

I can confirm that the issue is fixed with 1.1.38.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@si458 si458

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@si458 @KonVei82