Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if no nodes return nothing with getDeviceDetails using json #6637

Closed
DaanSelen opened this issue Dec 30, 2024 · 2 comments
Closed

if no nodes return nothing with getDeviceDetails using json #6637

DaanSelen opened this issue Dec 30, 2024 · 2 comments
Assignees
@si458
Labels
bug enhancement

Comments

@DaanSelen
Copy link

Describe the bug
If there are no nodes/agents configured inside MeshCentral, a call to it with: {"action": "getDeviceDetails", "type": "json"} will not generate a response, perhaps a null or empty list would suffice. Right now it times out on programs relying on it.

To Reproduce
Steps to reproduce the behavior:
Roll out a MeshCentral instance with no devices. and then request the {"action": "getDeviceDetails", "type": "json"}

Expected behavior
An empty list or response which says there is nothing to report.

Server Software (please complete the following information):

  • OS: Debian
  • Virtualization: Docker
  • Network: standard
  • Version: latest
  • Node: docker-dependant
@DaanSelen DaanSelen added the bug label Dec 30, 2024
@si458 si458 self-assigned this Dec 30, 2024
@DaanSelen
Copy link
Author

Thanks Simon!

@si458 si458 changed the title MeshCentral returns nothing on {"action": "getDeviceDetails", "type": "json"} if no nodes returns nothing with getDeviceDetails using json Jan 2, 2025
@si458 si458 changed the title if no nodes returns nothing with getDeviceDetails using json if no nodes return nothing with getDeviceDetails using json Jan 2, 2025
si458 added a commit that referenced this issue Jan 3, 2025
@si458
if no nodes return nothing for getDeviceDetails #6637
e66776c 
Signed-off-by: si458 <simonsmith5521@gmail.com>
@si458
Copy link
Collaborator

si458 commented Jan 3, 2025

all fixed e66776c
basically it looks for nodes, no nodes where returned, but it couldnt callback because the function to callback was inside the loop of nodes which oversally wont get called because the is no nodes

@si458 si458 closed this as completed Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@si458 si458

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@si458 @DaanSelen