This repository has been archived by the owner on Jul 18, 2018. It is now read-only.
Updated sample.py #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated oauth2.request call and the the url_params
|
This made things work for me. Thanks, @dennyglee! |
|
Glad it worked for you! |
|
Hey thanks a lot! This worked for me as well |
|
OK, that's certainly sufficient field testing. This definitely looks worth merging. |
| url_params = { | ||
| 'term': term, | ||
| 'location': location, | ||
| 'term': term.replace(' ', '+'), |
There was a problem hiding this comment.
Hm, I'd probably go with
urllib.quote_plus()
or similar here. That should take care of ' ' and some other tricky characters as well.
We don't want to go as far as urllib.urlencode() as we still want a dict for oauth2.Request().
Edit: Nope, my suggestion doesn't work well, going with yours.
|
Cool stuff :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated sample.py to take into account of spaces for the term and location as well as updated the oauth2.request call