Skip to content
This repository has been archived by the owner on Apr 18, 2018. It is now read-only.

Added trusted host argument to pip when running local pypi server #134

Closed
wants to merge 3 commits into from

Conversation

mzbyszynski
Copy link
Contributor

Fixes #133

@mzbyszynski
Copy link
Contributor Author

Oops, looks like I broke a unit test. I'll fix that shortly.

@imcom
Copy link
Contributor

imcom commented Jul 28, 2015

this patch is essential for building and testing pyleus on development stage

@poros
Copy link
Contributor

poros commented Jul 28, 2015

+1
That's a very good point!
I use an older version of pip, so I never noticed it.

@poros
Copy link
Contributor

poros commented Jul 28, 2015

Giving a second thought to it, it should possible to specify the same option in your pip.conf file and get away with it, without forcing pylues to do that for you.

I do not have a strong preference, but I am wondering if this change might break for old pip versions.

@mzbyszynski
Copy link
Contributor Author

I think older versions pip just ignore the argument, but I'll try and confirm tonight or tomorrow.

@mzbyszynski
Copy link
Contributor Author

Actually @poros you are right about the older versions of pip.. they barf on that argument. I think your pip.conf idea is a good solution. Maybe there just needs to be some note on the contributing page of the documentation that describes how to do this if you are using pip 7 or whatever version added the new trusted-host parameter?

imcom added a commit to imcom/pyleus that referenced this pull request Jul 29, 2015
@poros
Copy link
Contributor

poros commented Jul 29, 2015

Thank you for trying that out. Yes, a tip in the documentation is the best solution. Do you want to change this PR to do that so you get at least one commit with your name on it? Otherwise I'll do that as soon as I have some spare time.

@mzbyszynski
Copy link
Contributor Author

No need to wait for me. If I manage to get the pip.conf to work in my environment I'll write something up, if you don't get to it first.

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants