This repository has been archived by the owner on Apr 18, 2018. It is now read-only.
Remove explicit finish call in checklist that will cause 500 errors #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch. Can this be tested? |
|
Same conclusion for testing things in post() and get() functions as here: #133 (comment) This functionality really shouldn't exist in the RequestHandler themselves, in my opinion, but taking on everywhere that unnecessary logic exists in post and get request should be handled separately. |
|
Ok. Looks fine to me. |
kkellyy
added a commit
that referenced
this pull request
Nov 26, 2014
Remove explicit finish call in checklist that will cause 500 errors
kkellyy
added a commit
that referenced
this pull request
Dec 2, 2014
IMPROVEMENTS * Dynamic test tag loads on all pages now (kkellyy, #129) * Pushes can now include link to generic test runs of themselves (kkellyy, #130) * testtag servlet is now more robust: 404s on no id param and is asynchronous (kkellyy, #133) * Automatically detect and update SHA of request branches, notify the request's user and re-check for git conflicts if in pickme/added state (kkellyy, #134) BUG FIXES * copy_dict in core/util now ignores keys not defined in original dict (kkellyy, #130) * Pushmaster message users no longer case-sensitive (kkellyy, #130) * checklist servlet no longer generates spurious 500s (kkellyy, #132) * Explicitly add --no-rebase on git merge conflict testing to guaranteed git behvaior (kkellyy, #135) DEPRECATED * No longer gzip responses by default. (kkellyy, #131)
kkellyy
added a commit
that referenced
this pull request
Dec 3, 2014
IMPROVEMENTS * Dynamic test tag loads on all pages now (kkellyy, #129) * Pushes can now include link to generic test runs of themselves (kkellyy, #130) * testtag servlet is now more robust: 404s on no id param and is asynchronous (kkellyy, #133) * Automatically detect and update SHA of request branches, notify the request's user and re-check for git conflicts if in pickme/added state (kkellyy, #134, #137) BUG FIXES * copy_dict in core/util now ignores keys not defined in original dict (kkellyy, #130) * Pushmaster message users no longer case-sensitive (kkellyy, #130) * checklist servlet no longer generates spurious 500s (kkellyy, #132) * Explicitly add --no-rebase on git merge conflict testing to guaranteed git behvaior (kkellyy, #135) DEPRECATED * No longer gzip responses by default. (kkellyy, #131)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this function is not asynchronous, it is not necessary to call self.finish (it will be called when the post() returns). Doing so allows for the possibility of calling finish 2 times, which raises an exception and potentially throws a 500 error.