Allow for generic dynamic tag for testing frameworks to fill in data #126
Conversation
kkellyy
force-pushed
the
test_framework_dyn_tag
branch
from
474f462 to
c9eadee
Compare
| try: | ||
| api_url = Settings['tests_tag']['tag_api_endpoint'].replace('%SHA%', request['revision']) | ||
| api_body = Settings['tests_tag']['tag_api_body'].replace('%SHA%', request['revision']) | ||
| resp = urllib2.urlopen(api_url, api_body) |
There was a problem hiding this comment.
Is it possible for this to take a long time? We use asynchronous calls for the buildbot tag so that we don't delay page loads.
There was a problem hiding this comment.
It's possible. My planned endpoint is currently http-only currently, so making an async call from JS throws an error and fails. I can potentially cache on the api-side if slowness becomes an issue, but it's still possible.
There was a problem hiding this comment.
Can you smoke test this for a page with 20+ requests and see if performance is an issue? This will not be scalable, but it may be ok for now.
There was a problem hiding this comment.
Smoke tests show very heavy perf hit, especially if the test server is slow to respond.
|
Under load or slow response from test API, pushmanager's perf is severely impacted as well. Refactoring this now to make it asynchronous. |
kkellyy
force-pushed
the
test_framework_dyn_tag
branch
2 times, most recently
from
2657ba9 to
a3f0e09
Compare
| #User-added tag that will be replaced with api result | ||
| tag: "test-framework" | ||
| # JSON 'tag' value from POST response of this URL will replace tag | ||
| tag_api_endpoint: "http://example.com/api/v1/tests_tag" |
There was a problem hiding this comment.
Let's add a note here for the endpoints that this call could be either non-ssl or ssl regardless if the app itself is non-ssl or ssl.
kkellyy
force-pushed
the
test_framework_dyn_tag
branch
from
a3f0e09 to
d2149e3
Compare
|
Looks good now. shipit. |
Allow for generic dynamic tag for testing frameworks to fill in data
IMPROVEMENTS * Seagull is included in the quick tag list * Tests tag allows for generic support for any testing framework to dynamically populate a tag with test results and link to framework, similar to buidlbot (kkelly, #126)
Allows for user to define a name and API endpoints for a dynamic tag that can be populated arbitrarily with test results for a request. Also allows for API endpoints so that the tag can link to a detailed results page of the tests.