Skip to content
This repository has been archived by the owner on Apr 18, 2018. It is now read-only.

The 'git-ok' request tag now has gitweb link to the requested branch. #117

Merged
merged 2 commits into from
Sep 25, 2014

Conversation

kkellyy
Copy link
Contributor

@kkellyy kkellyy commented Sep 24, 2014

If a request has a git-ok tag, it will now be a link to the dev's requested branch.
Should save pushmaster time to go to the request to do the same thing.

@kkellyy kkellyy changed the title Add in check for git-ok tag and include gitweb branch link on it The 'git-ok' request tag now has gitweb link to the requested branch. Sep 24, 2014
@asottile
Copy link
Contributor

Add a test && :shipit:

@kkellyy
Copy link
Contributor Author

kkellyy commented Sep 24, 2014

I'm not seeing where this thing is being tested at all yet, so I can't decide where to include it.

@ymilki
Copy link
Member

ymilki commented Sep 25, 2014

We don't have any existing tests for ui_modules at all. A new test_ui_modules.py test file for this method would be sufficient.

ymilki added a commit that referenced this pull request Sep 25, 2014
The 'git-ok' request tag now has gitweb link to the requested branch.
@ymilki ymilki merged commit a3e8dcb into master Sep 25, 2014
ymilki added a commit to ymilki/pushmanager that referenced this pull request Sep 26, 2014
 IMPROVEMENTS

 * tags can contain the string 'conflict' again (asottile, Yelp#119)
 * 'git-ok' tag now links to gitweb (kkellyy, Yelp#117)
 * pushmanager is now proxy aware (kkellyy, Yelp#116)

 BUG FIXES

 * reviewboard links no longer contains the pushmanager port (kkellyy, Yelp#121)

 DEPRECATED

 * 'hoods' tag no longer has post-stage checklist steps (kkellyy, Yelp#120)
@asottile asottile deleted the git-ok_link_to_gitweb_branch branch September 27, 2014 23:53
ymilki added a commit to ymilki/pushmanager that referenced this pull request Sep 29, 2014
 IMPROVEMENTS

 * tags can contain the string 'conflict' again (asottile, Yelp#119)
 * 'git-ok' tag now links to gitweb (kkellyy, Yelp#117)
 * pushmanager is now proxy aware (kkellyy, Yelp#116)

 BUG FIXES

 * reviewboard links no longer contains the pushmanager port (kkellyy, Yelp#121)

 DEPRECATED

 * 'hoods' tag no longer has post-stage checklist steps (kkellyy, Yelp#120)
@ymilki ymilki mentioned this pull request Sep 29, 2014
ymilki added a commit that referenced this pull request Sep 29, 2014
 IMPROVEMENTS

 * tags can contain the string 'conflict' again (asottile, #119)
 * 'git-ok' tag now links to gitweb (kkellyy, #117)
 * pushmanager is now proxy aware (kkellyy, #116)

 BUG FIXES

 * reviewboard links no longer contains the pushmanager port (kkellyy, #121)

 DEPRECATED

 * 'hoods' tag no longer has post-stage checklist steps (kkellyy, #120)
ymilki added a commit that referenced this pull request Sep 29, 2014
 IMPROVEMENTS

 * tags can contain the string 'conflict' again (asottile, #119)
 * 'git-ok' tag now links to gitweb (kkellyy, #117)
 * pushmanager is now proxy aware (kkellyy, #116)
 * 'After certifying' checklist now says 'Before certifying' (kkellyy, #122)

 BUG FIXES

 * reviewboard links no longer contains the pushmanager port (kkellyy, #121)

 DEPRECATED

 * 'hoods' tag no longer has post-stage checklist steps (kkellyy, #120)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants