further upgrade Google libs #2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 18, 2019 12:07
…ud-dataproc 0.3.0 (google python libs set a maximum version for sub-deps in a way that's unhelpful)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2020, we upgraded
google-cloud-storageto version 1.11.0, allowing us to remove an awkward shim for setting bucket location.Unfortunately, Google library versions have to move somewhat in sync with each other, both because they require rather narrow bands of versions for sub-dependencies, and because at some point between the minimum versions in the last release and the ones in this pull request, something changed about how the various libraries share the
google.cloudpackage.What this means is that upgrading one of the three google libraries might not only result in warnings from
pip, but weird errors to the effect of "no such module google.cloud.logging".