Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image not getting rotated when it matches original image size #465

Closed
pablote opened this issue Oct 26, 2018 · 3 comments
Closed

Image not getting rotated when it matches original image size #465

pablote opened this issue Oct 26, 2018 · 3 comments

Comments

@pablote
Copy link

pablote commented Oct 26, 2018

Do you want to request a feature or report a bug?

Bug

What is the current behavior?

If the user rotates an image by exactly 90 degrees, it then chooses the exact inverse aspect ratio (say the image was taken in 16:9, then choose 9:16), and the selection frame is chosen so that it fully selects the image, uCrop seems to be returning the original image, without respecting the user's rotation. This does not happen if the rotation drifts slightly from 90, or even if selection crops the image a bit.

What is the expected behavior?

I would expect that if a user only rotates an image, then uCrop should return a new rotated image. As I said earlier, this is already the case if the rotation is not exactly 90, or if the images gets cropped a bit.

uCrop 2.2.2
android 7.1.1

@p1nkydev
Copy link
Contributor

@pablote It will be fixed in the next release.

@jackyhieu1211-hn
Copy link

@p1nkydev
Hello
Has this problem been fixed?

@p1nkydev
Copy link
Contributor

@hieuseesaa Checked right now and yes, after rotation crop area is exactly like image's side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants