refactor: refactor climate.py #614
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe the title should be refractor, not refacor? |
|
|
topsworld
reviewed
Jan 22, 2025
| elif prop.name == 'ac-state': | ||
| self._prop_ac_state = prop | ||
| self._value_ac_state = {} | ||
| self.sub_prop_changed( | ||
| prop=prop, handler=self.__ac_state_changed) | ||
|
|
||
| # hvac modes | ||
| if HVACMode.OFF not in self._attr_hvac_modes: | ||
| if self._attr_hvac_modes is None: |
There was a problem hiding this comment.
An exception will occur here because _attr_hvac_modes is not initialized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Thermostat, heater, bath heater needs to be added as the climate entity. However, the previous climate.py has many repetitive codes. This PR refactors climate.py by setting several base classes.
Added
Supporting thermostat and ptc bath heater.
Test
Self-tested with some limited model.