Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate number of fishers #75

Merged
merged 4 commits into from
Dec 2, 2021
Merged

Validate number of fishers #75

merged 4 commits into from
Dec 2, 2021

Conversation

efcaguab
Copy link
Contributor

@efcaguab efcaguab commented Nov 30, 2021 •
edited
Loading

The purpose of this pull request is to add the number of fishers into the pipeline so it can be used in the portal.

New features

  • New alert for outlier in number of fishers in airtable (alert number 18)
  • New columns in the public trips data frame, namely fisher_n_man, fisher_n_woman, and fisher_n_child
  • New columns in the public aggregated data frame, namely prop_landings_woman with the proportion of landings where a woman was recorded

Issues fixed

  • Added other columns that have been validated but were not included in the clean trips_table data frame that's exported

@efcaguab efcaguab marked this pull request as ready for review December 1, 2021 02:34
@efcaguab efcaguab requested a review from langbart December 1, 2021 02:35
Update with main, added site_alerts and fishers_alerts in handle flag…
6db1189 
… seciton

Merge branch 'main' of https://github.com/WorldFishCenter/peskas.timor.data.pipeline into feat/n_fishers
# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
langbart
langbart requested changes Dec 1, 2021
View reviewed changes
Copy link
Member

@langbart langbart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @efcaguab, I have just updated with main and added site and fishers alerts in flag handling

@efcaguab
Copy link
Contributor Author

efcaguab commented Dec 2, 2021

Hey @efcaguab, I have just updated with main and added site and fishers alerts in flag handling

Thanks for tidying it up!!! Appreciate it! I'll go ahead and merge it.

@efcaguab efcaguab merged commit 9a20e8d into main Dec 2, 2021
@langbart langbart deleted the feat/n_fishers branch December 3, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langbart langbart langbart requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@efcaguab @langbart