replace with same editorconfig as used in gutenberg #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnhooks
approved these changes
Apr 21, 2023
There was a problem hiding this comment.
I agree with this change. I didn't initially notice because I already have VSCode set to display tabs as 2 spaces which overrides the setting in the editor config. Though tabs, spaces and display width can be a contentious subject. We have chooses tabs but should leave display width to personal preference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
I realised that the editorconfig was changed but that configuration always gave me troubles with js/webstorm, and may lead to a worse development experience
Why?
tab_width = 4is forcing the ide to use this setting whereas if you do not set anything, you have the option of using your preference from the ide.Fixes
Yamlfiles that should not use tabsHow?
Copy and pasted the gutenberg config file that is working fine https://github.com/WordPress/gutenberg/blob/trunk/.editorconfig