CSS - Moving to "purpose naming" convention #273
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Css custom props were definitely a great innovation and allow you to share the colors of your stylesheet. However, too many plugins end up creating their own color set libraries in the root and you end up with the opposite effect
Why?
IMHO the problem arise because the name of the color is used to set the variable name, and this eventually forces all plugins to create a variable for each color used. This PR makes this plugin follow another method which is to use the names on the purpose that the variables have (and thus success, error etc)
Several articles that talk about this can be found (eg. this or this), it seems to me a very good improvement to do to clean up and simplify the style
How?
to