Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eslint issue #233

Merged
merged 3 commits into from
Apr 4, 2023
Merged

fix: eslint issue #233

merged 3 commits into from
Apr 4, 2023

Conversation

johnhooks
Copy link
Collaborator

@johnhooks johnhooks commented Apr 4, 2023

What?

Fix ESLint / Prettier configuration.

Fixes Issue #220

Why?

Apparently there is something called wp-prettier which is a maintained fork of prettier, just to add WP styling. There is a whole thing, if you want to dive deep here are some links:

I think some other dependency must have overridden the overriding of prettier by @wordpress/scripts's wp-prettier. But now the package.json explicitly states we are using wp-prettier in place of prettier.

@johnhooks johnhooks requested a review from erikyo April 4, 2023 04:09
Copy link
Collaborator

@erikyo erikyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@erikyo erikyo merged commit 9e74235 into WordPress:develop Apr 4, 2023
@johnhooks johnhooks deleted the fix/eslint-issue branch April 4, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants