[Blueprints] Document why autologin uses absolute URLs for redirects #1971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgrgicak
added
[Type] Documentation
adamziel
reviewed
Oct 31, 2024
| * | ||
| * The WordPress home url always includes a site scope subdirectory. | ||
| * We expect the REQUEST_URI to include the site scope subdirectory, | ||
| * but if a request is made using a request handler it's possible |
There was a problem hiding this comment.
What does it mean that a request is made using a request handler? As in the request handler issues another request?
| */ | ||
| $redirect_url = $_SERVER['REQUEST_URI']; | ||
| if (strpos($redirect_url, '/scope:') === 0) { | ||
| $parts = explode('/', $redirect_url); | ||
| $redirect_url = '/' . implode('/', array_slice($parts, 2)); | ||
| } | ||
| wp_redirect( | ||
| /** | ||
| * Safari breaks if the redirect URL is relative so we always |
There was a problem hiding this comment.
Let's briefly explain what does "breaks" mean
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR explains why autologin uses absolute URLs for redirects by improving the inline documentation of the autologin code.
Testing Instructions (or ideally a Blueprint)