Website: Stop disabling cache for non-root index.html files #1461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a general improvement, but it was done so we could stop moving puzzle/index.html aside to be served by PHP. When puzzle/index.html is set aside, it turns out that nginx does not delegate the request to PHP but rather responds with a 403 error. We plan to talk with the host about fixing this behavior, but in the meantime, we can avoid it here.
brandonpayton
added
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
This PR makes it so the only
index.htmlfile set aside to get custom HTTP headers is/index.html.What problem is it solving?
It is a general improvement for us to be more specific about which file paths get special treatment, but we are making the change now so we can stop setting puzzle/index.html aside to be served by PHP. cc @bgrgicak
How is the problem addressed?
When puzzle/index.html is set aside, it turns out that nginx does not delegate the request to PHP but rather responds with a 403 error. Nginx appears to do this for every existing, non-root directory. We plan to talk with the host about fixing this behavior, but in the meantime, we can avoid it here by excluding puzzle/index.html from receiving "no-cache" headers.
Testing Instructions
I have tested these changes manually via SSH on a staging site. After merging, we will deploy the website and confirm all is well in production.