Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Use time_format setting in update-core.php screen instead of hardcoding #7921

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Core: Use time_format setting in update-core.php screen instead of hardcoding #7921

wants to merge 2 commits into from

Conversation

himanshupathak95
Copy link

@himanshupathak95 himanshupathak95 commented Nov 29, 2024 •
edited
Loading

Trac ticket: 62616

The update-core.php screen was displaying date and time using hardcoded formats instead of respecting the formats chosen by users in Settings > General.

This PR changes the hardcoded time format and date format to use get_option('time_format') and get_option('date_format')

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 29, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props abcd95, sunil25393.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

akasunil
akasunil suggested changes Nov 29, 2024
View reviewed changes
Copy link
Member

@akasunil akasunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. I appreciate your contribution. Although it is outside the scope of this issue, but it would be convenient if you could also use the user selected date format here.

src/wp-admin/update-core.php Outdated
@@ -1112,7 +1112,7 @@ function do_undismiss_core_update() {
/* translators: Last update date format. See https://www.php.net/manual/datetime.format.php */
date_i18n( __( 'F j, Y' ), $last_update_check ),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set date format too.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @akasunil, Thanks for the suggestion.

I have made the changes.

@github-actions GitHub Actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

akasunil
akasunil approved these changes Nov 30, 2024
View reviewed changes
Copy link
Member

@akasunil akasunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akasunil akasunil akasunil approved these changes

At least 10 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@himanshupathak95 @akasunil