Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SimplePie to version 1.8.0 #7124

Closed
wants to merge 2 commits into from

Conversation

faisal-alvi
Copy link

Trac ticket: https://core.trac.wordpress.org/ticket/55604


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

github-actions bot commented Aug 1, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props faisal03, mukesh27, peterwilsoncc.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

github-actions bot commented Aug 1, 2024

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@mukeshpanchal27
Copy link
Member

The PR only have one file change, There should be more per simplepie/simplepie@1.5.8...1.8.0

@faisal-alvi
Copy link
Author

@mukeshpanchal27 I've added more files, but since the new version uses PSR-4, @peterwilsoncc suggested including the src folder as well. I'm still figuring out how to do that.

@faisal-alvi
Copy link
Author

@mukeshpanchal27 just following up on the blocker here. Can you please ping someone who can review or help with this PR?

@peterwilsoncc
Copy link
Contributor

@faisal-alvi I did some very rough experimenting with dropping the simple pie zip in to the existing folder (ie, moving the library files in to the library directory) and replacing inclusion of files with their new autoloader.

It wasn't super successful as WP_Feed_Cache_Transient is now required to implement SimplePie\Cache\Base which is not the case.

IN short, it loosk like there will be quite a bit of messing around require to upgrade to 1.8.0.

@SergeyBiryukov
Copy link
Member

Thanks for the PR! This is now resolved in r59141.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants