Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor update_ignored_hooked_blocks_postmeta to use meta_input #6885

Closed
wants to merge 1 commit into from
Closed

Refactor update_ignored_hooked_blocks_postmeta to use meta_input #6885

wants to merge 1 commit into from

Conversation

tjcafferkey
Copy link

@tjcafferkey tjcafferkey commented Jun 24, 2024 •
edited
Loading

This is a prerequisite to adding hooked blocks to template parts at positions first_child and last_child #6867

It's necessary because unlike wp_navigation post, the wp_template_part posts won't have a database entry upon first save meaning that update_post_meta won't work. To circumvent this we are now setting meta information on the $post stdClass object via the meta_input field which will get saved as post meta when its created/updated in the database.

Trac ticket: https://core.trac.wordpress.org/ticket/61495

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@tjcafferkey tjcafferkey mentioned this pull request Jun 24, 2024
Closed
@github-actions GitHub Actions
Copy link

Trac Ticket Missing

This pull request is missing a link to a Trac ticket. For a contribution to be considered, there must be a corresponding ticket in Trac.

To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. More information about contributing to WordPress on GitHub can be found in the Core Handbook.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 24, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props tomjcafferkey, bernhard-reiter.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions GitHub Actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@ockham
Copy link
Contributor

ockham commented Jun 25, 2024

Some additional background here.

ockham
ockham approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@ockham ockham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ockham
Copy link
Contributor

ockham commented Jun 26, 2024

Committed to Core trunk in https://core.trac.wordpress.org/changeset/58578.

@ockham ockham closed this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ockham ockham ockham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tjcafferkey @ockham