-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imgAreaSelect: Fix doResize without initialized values #2302
base: trunk
Are you sure you want to change the base?
imgAreaSelect: Fix doResize without initialized values #2302
Conversation
Hi @arthur791004! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in this blog post. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
@arthur791004 I'm curious if you could add a test for this, seems like if there had been a test case, this bug would have been caught with ates. |
@arthur791004 Should this be closed in favor of #1774? |
Merged/resolved in changeset 54903. This PR can be closed. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @autumnfjeld, @walak19573, @supernovia, @sstabrizi, @Robertght, @khristiansnyder, @MaxPhilip, @jp-imagines, @sajmes, @kwight, @aamills, @ahmadbaig1, @daria2303, @cometgrrl, @zdenys, @katiebethbrown, @alshakero, @Matrixverse, @mzitinfo, @renata-franco, @rw-ye, @Sandkorner, @inaikem, @wpshellbelle, @jamiepalatnik, @rinazrina, @aleone89, @the-misha, @sharonlaker19, @JessBoctor. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Trac ticket: https://core.trac.wordpress.org/ticket/54308#ticket
Fixes Automattic/wp-calypso#52182
If the doResize is called without initialized the x1, x2, y1 and y2 values, it causes x1 is NaN and then the selection area would be wrong.
Why do
doResize
call at the beginning? AsimgAreaSelect
usesMath.round
for calculation and the height/width of image is non-integer, it will make the following condition becomes trueThus, #1774 replacing
Math.round
withMath.floor
fixes the issue.This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.