Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parameter types in docblocks #2234

Closed
wants to merge 1 commit into from
Closed

Fix parameter types in docblocks #2234

wants to merge 1 commit into from

Conversation

sjinks
Copy link

@sjinks sjinks commented Jan 27, 2022

This PR fixes parameter/return value types for the translations_api() function and translations_api and translations_api_result hooks from object to array.

Trac ticket:


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@audrasjb
Copy link
Contributor

committed in https://core.trac.wordpress.org/changeset/52645, thanks!

@audrasjb audrasjb closed this Jan 27, 2022
@valerio-bozzolan
Copy link

Sorry for this question but how can someone from https://core.trac.wordpress.org/changeset/52645 discover the original author (that is @sjinks and not @audrasjb)? Just for my curiosity.

@sjinks
Copy link
Author

sjinks commented Jan 31, 2022

@valerio-bozzolan "props volodymyrkolesnykov" in the commit message 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants