Fix imageareaselect bug for non-integer image dimensions #1774
Conversation
Floor numbers instead of rounding them
alshakero
changed the title
|
@arthur791004 @alshakero |
|
@autumnfjeld AFAICT, my PR is sufficient to resolve the issue because it circumvents the issue solved in #2302. I explored both approaches in my trac ticket. |
|
@alshakero Thanks for adding my approach to your trac ticket! I think your PR is good and it can fix the case you mentioned. But I'm not sure there is any other case or not. For example, it seems that the developer can set the initial selection via options here. If the value is greater than image width/height, it might resolve |
|
@arthur791004 that's a great point! |
|
@alshakero Just curious if there are any blockers to finishing this work. Did you need any further assistance? cc: @arthur791004 |
|
Hi @autumnfjeld! I'm just waiting for review in Trac. Is there anything I can do to accelerate getting this merged? |
|
I think the PR needs to either rebase on trunk, or merge trunk to resolve the test failure on PHP 8.2 single site. |
|
Hi @costdev! Thanks. I rebased it 👍🏼 |
|
Merged/resolved in changeset 54903. This PR can be closed. |
Trac ticket: https://core.trac.wordpress.org/ticket/54308#ticket
The ticket has all the information needed.
Fixes Automattic/wp-calypso#52182
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.