Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Conversation

2ndkauboy
Copy link

@2ndkauboy 2ndkauboy commented Oct 15, 2024

For those footers having the site title already, the additional block is removed.

tt5-574.mp4

For those footers having the site title already, the additional block is removed.
Copy link

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

Copy link

github-actions bot commented Oct 15, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: 2ndkauboy <kau-boy@git.wordpress.org>
Co-authored-by: beafialho <beafialho@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@2ndkauboy
Copy link
Author

Changes #574

@beafialho
Copy link
Contributor

Thanks for your suggestion. As mentioned here this significantly changes the design of the footers, adds redundancy and looks unbalanced.

@2ndkauboy
Copy link
Author

@beafialho I specifically tried not to have any redundancy by using the site title only in footer, where it is not already somewhere else (see video).

@juanfra juanfra deleted the branch WordPress:update/remove-block-binding October 17, 2024 14:14
@juanfra juanfra closed this Oct 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants