Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove auto_sizes_get_layout_settings() #1743

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Conversation

mukeshpanchal27
Copy link
Member

Summary

Follow-up on #1737

In 35988a4, we removed the static cache. Since the function was originally created for cache implementation and is now removed, it’s no longer needed. Instead, we can directly incorporate the one-line global setting code into the function where it is used.

@mukeshpanchal27 mukeshpanchal27 added [Type] Enhancement A suggestion for improvement of an existing feature [Plugin] Enhanced Responsive Images Issues for the Enhanced Responsive Images plugin (formerly Auto Sizes) labels Dec 16, 2024
@mukeshpanchal27 mukeshpanchal27 added this to the auto-sizes 1.4.0 milestone Dec 16, 2024
@mukeshpanchal27 mukeshpanchal27 self-assigned this Dec 16, 2024
@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review December 16, 2024 04:55
Copy link

github-actions bot commented Dec 16, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>
Co-authored-by: felixarntz <flixos90@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@felixarntz felixarntz merged commit efabb2b into trunk Dec 16, 2024
14 checks passed
@felixarntz felixarntz deleted the update/1737-follow-up branch December 16, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Enhanced Responsive Images Issues for the Enhanced Responsive Images plugin (formerly Auto Sizes) [Type] Enhancement A suggestion for improvement of an existing feature
Projects
Status: Done 😃
Development

Successfully merging this pull request may close these issues.

3 participants