Block Editor Storybook: Restructure the directory and add badges to private components #68352
+11
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rivate components
t-hamano
added
[Package] Block editor
|
Size Change: 0 B Total Size: 1.84 MB ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in ac9535a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12516428579
|
t-hamano
changed the title
|
@Mamaduka Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? / Why?
Because of #58123 and #58518, badges have been added to the private components published as
@wordpress/components.Meanwhile, private components published in the
@wordpress/block-editorpackage are classified in a separate directory. That means the current Storybook is structured as follows:This PR also adds badges to the block editor package, as well as the component package.
Furthermore, because adding badges means that a directory for the private API is no longer necessary, restructure it as follows:
How?
The components that will be badged by this PR are actually the following three:
DimensionsToolResolutionToolTextAlignmentControlThe
DimensionsToolcomponent is composed of three subcomponents,AspectRatioTool,ScaleTool, andWidthHeightTool. These three subcomponents cannot be used independently. It may not be necessary to publish them as a storybook, but for now, I will give private badges to these subcomponents as well. In the future, we might be able to expose each of these three subcomponents as standalone components.Testing Instructions
npm run storybook:dev