-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix VS Code performance #68347
Fix VS Code performance #68347
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jsconfig.json
to improve VS Code performance
I read about jsconfig here and I think it should probably be removed. My concern is that there are a number of packages that do not have tsconfig.json and would not be covered. packages without `tsconfig.json`find packages -mindepth 1 -maxdepth 1 -type d '!' -exec sh -c 'ls -1 "{}"|grep -E -i -q "^tsconfig.json$"' ';' -print
Should these packages first get a basic tsconfig.json file and be added to the main tsconfig? |
Flaky tests detected in eb4da08. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12515496285
|
It was added in #8043 to have IntelliSense, which should still work because we declare the dependencies in package.json for each package and we now use npm workspaces, which inegrates even better. Here is an example in Screen.Recording.2024-12-27.at.5.22.44.PM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try it 👍
What?
Improve VS Code performance by removing
jsconfig.json
file.Why?
If you open the project in VS Code and open a file like
test/native/integration/blocks-raw-handling.native.js
, you will see this warning:The reason is the presence of
jsconfig.json
file that is outdated and hasn't been updated in 6 years apart from a formatting change 3 years ago.VS Code seems to prefer
jsconfig
overtsconfig
if it's present and thus that warning.Now that the project has a good TS structure and a root
tsconfig
, we can get rid of thatjsconfig
to give VS Code some relief.How?
By nuking
jsconfig.json
Testing Instructions
test/native/integration/blocks-raw-handling.native.js
Developer: Reload Window
Testing Instructions for Keyboard
Screenshots or screencast