Fix tsconfig for test/ directory #68346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.84 MB ℹ️ View Unchanged
|
sirreal
reviewed
Dec 27, 2024
Comment on lines
+63
to
+64
| { "path": "test/e2e" }, | ||
| { "path": "test/performance" } |
There was a problem hiding this comment.
These should certainly be here 👍
|
Flaky tests detected in a0145d0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12515824515
|
sirreal
approved these changes
Dec 27, 2024
sirreal
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Currently, the files inside
test/directory are not checked for TS errors by our static type checking which means if any TS error is introduced in those files, we won't know about it.This PR:
@types/nodeas a dependency to allow its inclusion intsconfig.jsonfiles intest/e2eandtest/performancedirectoriestsconfig.jsonfiles for e2e and performance test directories to addrootDir, which was not done in Build: Simplify tsconfig.json files #68326 (comment)test/e2eandtest/performanceto roottsconfig.jsonreferences to include them for typecheckingWhy?
To ensure that the test files are type checked
How?
Testing Instructions
test/e2e/specspm run build:package-typesTesting Instructions for Keyboard
Screenshots or screencast