Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

theme.json schema: Fix block list #68343

Merged
merged 1 commit into from
Dec 28, 2024
Merged

theme.json schema: Fix block list #68343

merged 1 commit into from
Dec 28, 2024

Conversation

t-hamano
Copy link
Contributor

What?

I noticed that the list of blocks in the theme.json schema was incorrect.

How?

  • core/footnotes: This is already shipped in the core, so we need to add it.
  • core/query-total: This block isn't experimental and should be included in the next WordPress release, so we should add it.
  • core/post-time-to-read、core/table-of-contents: These blocks are not included in the core because the __experimental field is true, so I think they should be excluded from the schema.

Testing Instructions

  • Open the test/emptytheme/theme.json file in a code editor.
  • Add the following fields. Verify that the correct blocks appear in the block list (or that experimental blocks don't appear).
    • settings.blocks
    • styles.blocks
    • styles.variations.test.blocks

@t-hamano t-hamano added the [Type] Developer Documentation Documentation for developers label Dec 27, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 27, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions GitHub Actions
Copy link

Flaky tests detected in df2b0c7.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12513988020
📝 Reported issues:

Mamaduka
Mamaduka approved these changes Dec 27, 2024
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @t-hamano!

@t-hamano
Copy link
Contributor Author

@Mamaduka Thanks for the review!

@t-hamano t-hamano merged commit b4304f8 into trunk Dec 28, 2024
69 of 70 checks passed
@t-hamano t-hamano deleted the theme-json/fix-block-list branch December 28, 2024 08:50
@github-actions github-actions bot added this to the Gutenberg 20.0 milestone Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mamaduka Mamaduka Mamaduka approved these changes

@scruffian scruffian Awaiting requested review from scruffian

@ajlende ajlende Awaiting requested review from ajlende

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy

Assignees
No one assigned
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 20.0
Development

Successfully merging this pull request may close these issues.
2 participants
@t-hamano @Mamaduka