MediaReplaceFlow: Remove store subscription in favor of modern CSS #68276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
|
Size Change: -3 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 9e479d2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12483545401
|
t-hamano
approved these changes
Dec 25, 2024
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Thanks, @t-hamano! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR fixes a condition for the
MediaReplaceFlowform element when it shouldn't render a separation border.After recent updates, I noticed that the
has-siblingscondition was out of sync. Instead of updating it, I decided to switch to a CSS-only solution.Why?
NavigableMenuhas child elements. This can be derived with just CSS.getSettings().mediaUploadis only called inside the callback, a component can use a static selector getter and avoid store subscription.Testing Instructions
block-editor-media-replace-flow__media-upload-menudiv.Testing Instructions for Keyboard
Same.
Screenshots or screencast