Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tools Panel dropdown menu props to More block #68039

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Add Tools Panel dropdown menu props to More block #68039

merged 1 commit into from
Dec 23, 2024

Conversation

Infinite-Null
Copy link
Contributor

Part of: #68019

What?

Enhances the More block's ToolsPanel by adding support for dropdown menu functionality through the useToolsPanelDropdownMenuProps hook.

Screenshots

Before After
image image

@github-actions GitHub Actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Infinite-Null <ankitkumarshah@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@im3dabasia im3dabasia mentioned this pull request Dec 17, 2024
Merged
@Infinite-Null
Copy link
Contributor Author

Hi @fabiankaegy,
This PR follows up on adding dropdown menu props to the ToolsPanel component of the More block. The initial changes have already been merged.

I have followed this comment.

cc: @adamsilverstein

t-hamano
t-hamano approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@t-hamano t-hamano added [Type] Enhancement A suggestion for improvement. [Block] More Affects the More Block - used for displaying the 'Read More' link props-bot Adding this label triggers the Props Bot workflow for a PR. labels Dec 23, 2024
@t-hamano t-hamano merged commit 5a59c03 into WordPress:trunk Dec 23, 2024
70 of 74 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.0 milestone Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-hamano t-hamano t-hamano approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

Assignees
No one assigned
Labels
[Block] More Affects the More Block - used for displaying the 'Read More' link props-bot Adding this label triggers the Props Bot workflow for a PR. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 20.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Infinite-Null @t-hamano