Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Link: Add "Open in new tab" toggle to navigation block sidebar #67262

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

Infinite-Null
Copy link
Contributor

@Infinite-Null Infinite-Null commented Nov 25, 2024

Fixes: #67246

What?

Adds the "Open in new tab" toggle option to the Navigation Link block's settings sidebar, making it accessible alongside other link settings.

Why?

Currently, the "Open in new tab" setting is only available within the link modal of the context menu, while all other link options are presented in the block settings sidebar. This inconsistent placement has confused editors trying to locate this commonly used option.

Screenshots or screencast

After Patch (2)

Copy link

github-actions bot commented Nov 25, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Infinite-Null <ankitkumarshah@git.wordpress.org>
Co-authored-by: relic-se <ogrecooper@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@carolinan carolinan added the Needs Design Feedback Needs general design feedback. label Nov 25, 2024
@t-hamano t-hamano added [Block] Navigation Link Affects the Navigation Link Block [Type] Enhancement A suggestion for improvement. labels Nov 25, 2024
@relic-se
Copy link

Thanks for getting on top of this, @Infinite-Null ! My only suggestion is that I feel the ToggleControl should be placed underneath "Link" rather than at the top of the Navigation Link block settings.

@Infinite-Null
Copy link
Contributor Author

Thanks for getting on top of this, @Infinite-Null ! My only suggestion is that I feel the ToggleControl should be placed underneath "Link" rather than at the top of the Navigation Link block settings.

Hi @relic-se,

Thank you for the valuable suggestion! is this correct?
image

@relic-se
Copy link

Yes, that looks great. I think you've provided a quick, simple solution for this problem. All clear with me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Link Affects the Navigation Link Block Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation Link Block: Open in new tab
4 participants