Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin: Bump minimum required WordPress version to 6.5 #64126

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Plugin: Bump minimum required WordPress version to 6.5 #64126

merged 1 commit into from
Jul 31, 2024

Conversation

Mamaduka
Copy link
Member

What?

Similar to #60780.
Related to #64096.

Bumps the "Required WP version" field to 6.5, and the "Tested up to" field to 6.6. It also updates the performance test base hash.

Why?

See https://developer.wordpress.org/block-editor/explanations/architecture/performance/#update-the-reference-commit

How?

Testing Instructions

  • CI checks should be green.
  • Confirm that new commit SHA matches guidelines.

@Mamaduka Mamaduka added [Type] Enhancement A suggestion for improvement. Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts labels Jul 31, 2024
@Mamaduka Mamaduka self-assigned this Jul 31, 2024
@Mamaduka Mamaduka requested a review from desrosj as a code owner July 31, 2024 04:49
@Mamaduka Mamaduka mentioned this pull request Jul 31, 2024
Merged
talldan
talldan approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for handling this.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 31, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: talldan <talldanwp@git.wordpress.org>
Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka
Copy link
Member Author

Thanks, @talldan!

@youknowriad, can you confirm that the new perf SHA looks okay to you?

ramonjd
ramonjd approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@ramonjd ramonjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/performance.yml Show resolved Hide resolved
@Mamaduka Mamaduka merged commit 25af7e3 into trunk Jul 31, 2024
73 checks passed
@Mamaduka Mamaduka deleted the update/minimum-wp-version-to-6-5 branch July 31, 2024 08:13
@github-actions github-actions bot added this to the Gutenberg 19.0 milestone Jul 31, 2024
@ockham ockham mentioned this pull request Nov 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramonjd ramonjd ramonjd approved these changes

@talldan talldan talldan approved these changes

@desrosj desrosj Awaiting requested review from desrosj desrosj is a code owner

@ockham ockham Awaiting requested review from ockham

@youknowriad youknowriad Awaiting requested review from youknowriad

@ellatrix ellatrix Awaiting requested review from ellatrix

Assignees

@Mamaduka Mamaduka

Labels
Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 19.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Mamaduka @youknowriad @talldan @ramonjd