Add letter spacing inheritance for the navigation block #62745
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @graylaurenm. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
github-actions
bot
added
the
First-time Contributor
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @graylaurenm! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
talldan
added
[Block] Navigation
There was a problem hiding this comment.
Thanks for the contribution @graylaurenm! The fix looks good to me.
For anyone testing, you have to set Submenus > 'Open on click' in the navigation block's settings to notice the bug. When you do that, letter spacing doesn't affect the submenu button.
talldan
added
the
Backport to WP 6.7 Beta/RC
Unlinked contributors: graylaurenm. Co-authored-by: talldan <talldanwp@git.wordpress.org>
|
I just cherry-picked this PR to the wp/6.6-rc-1 branch to get it included in the next release: 88002da |
ellatrix
added
Backported to WP Core
Unlinked contributors: graylaurenm. Co-authored-by: talldan <talldanwp@git.wordpress.org>
What?
Adds inheritance of letter spacing for the navigation block.
Why?
The navigation block uses
inheritdefinitions to support typography styles. Theletter-spacingdefinition is missing.How?
Adds the necessary line.
Testing Instructions
<!-- wp:navigation {"ref":60591,"style":{"typography":{"letterSpacing":"0.1em"}}} /-->Testing Instructions for Keyboard
N/A
Screenshots or screencast
Before:
After:
