Remove polyfills from view.js block scripts #35038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.07 MB ℹ️ View Unchanged
|
aristath
force-pushed
the
remove/frontend-polyfills
branch
from
2315a04 to
1be1d71
Compare
gziolo
reviewed
Oct 4, 2021
|
Can we clarify what polyfills are we removing from view.js scripts here? I actually thought all our scripts didn't include any polyfill because we have a separate |
In WP-Admin, we always set |
Exactly. We may need |
aristath
force-pushed
the
remove/frontend-polyfills
branch
from
1be1d71 to
0301d20
Compare
gziolo
approved these changes
Oct 5, 2021
There was a problem hiding this comment.
It looks good from my perspecitve. Let's wait for @youknowriad to confirm we are on the same page.
We will have to apply the same changes in the WordPress core.
vcanales
approved these changes
Oct 5, 2021
|
Works for me 👍 If I understood properly, we don't add |
Correct 👍 |
mkaz
added a commit
to WordPress/gutenberg-examples
that referenced
this pull request
Oct 6, 2021
With the merging of WordPress/gutenberg#35038 the wp-polyfill is no longer a required dependency for the blocks.
mkaz
added a commit
to WordPress/gutenberg-examples
that referenced
this pull request
Oct 8, 2021
With the merging of WordPress/gutenberg#35038 the wp-polyfill is no longer a required dependency for the blocks.
nylen
pushed a commit
to nylen/wordpress-develop-svn
that referenced
this pull request
Nov 4, 2021
Related changes in Gutenberg: WordPress/gutenberg#35038. When adding a block with a view.js script, the frontend loads an additional ~20kb of scripts that were previously not there. These are coming from polyfills that are defined as a dependency for view.js scripts. Since WordPress dropped support for IE, these polyfills are no longer needed and can be removed. Follow-up to [51501]. See #53690. Props aristath. git-svn-id: https://develop.svn.wordpress.org/trunk@52011 602fd350-edb4-49c9-b593-d223f7449a82
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Nov 4, 2021
Related changes in Gutenberg: WordPress/gutenberg#35038. When adding a block with a view.js script, the frontend loads an additional ~20kb of scripts that were previously not there. These are coming from polyfills that are defined as a dependency for view.js scripts. Since WordPress dropped support for IE, these polyfills are no longer needed and can be removed. Follow-up to [51501]. See #53690. Props aristath. git-svn-id: https://develop.svn.wordpress.org/trunk@52011 602fd350-edb4-49c9-b593-d223f7449a82
|
Backported to WordPress core in https://core.trac.wordpress.org/changeset/52011. |
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Nov 4, 2021
Related changes in Gutenberg: WordPress/gutenberg#35038. When adding a block with a view.js script, the frontend loads an additional ~20kb of scripts that were previously not there. These are coming from polyfills that are defined as a dependency for view.js scripts. Since WordPress dropped support for IE, these polyfills are no longer needed and can be removed. Follow-up to [51501]. See #53690. Props aristath. Built from https://develop.svn.wordpress.org/trunk@52011 git-svn-id: http://core.svn.wordpress.org/trunk@51602 1a063a9b-81f0-0310-95a4-ce76da25c4cd
gMagicScott
pushed a commit
to gMagicScott/core.wordpress-mirror
that referenced
this pull request
Nov 4, 2021
Related changes in Gutenberg: WordPress/gutenberg#35038. When adding a block with a view.js script, the frontend loads an additional ~20kb of scripts that were previously not there. These are coming from polyfills that are defined as a dependency for view.js scripts. Since WordPress dropped support for IE, these polyfills are no longer needed and can be removed. Follow-up to [51501]. See #53690. Props aristath. Built from https://develop.svn.wordpress.org/trunk@52011 git-svn-id: https://core.svn.wordpress.org/trunk@51602 1a063a9b-81f0-0310-95a4-ce76da25c4cd
costdev
pushed a commit
to costdev/wordpress-develop
that referenced
this pull request
Nov 28, 2021
Related changes in Gutenberg: WordPress/gutenberg#35038. When adding a block with a view.js script, the frontend loads an additional ~20kb of scripts that were previously not there. These are coming from polyfills that are defined as a dependency for view.js scripts. Since WordPress dropped support for IE, these polyfills are no longer needed and can be removed. Follow-up to [51501]. See #53690. Props aristath. git-svn-id: https://develop.svn.wordpress.org/trunk@52011 602fd350-edb4-49c9-b593-d223f7449a82
goldentroll
added a commit
to goldentroll/gutenberg-examples
that referenced
this pull request
Mar 13, 2023
With the merging of WordPress/gutenberg#35038 the wp-polyfill is no longer a required dependency for the blocks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When adding a block with a
view.jsscript, the frontend loads an additional ~20kb of scripts that were previously not there. These are coming from polyfills that are defined as a dependency forview.jsscripts.Since WordPress dropped support for IE, these polyfills are no longer needed and can be removed.
This will improve performance and sustainability.
How has this been tested?
Tested with the navigation block in Safari & Firefox, confirmed that everything works both on the frontend and the editor.
Confirmed that the extra assets are no longer loaded on the frontend.
Checklist:
*.native.jsfiles for terms that need renaming or removal).