Webpack: Fix watch on .json and .php files
#34024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only ignore watch on files in the src folder that are handled by the build script. This fixes a bug where `.json` and `.php` files in blocks isn't copied in development mode.
gziolo
approved these changes
Aug 12, 2021
There was a problem hiding this comment.
Great catch, that makes a lot of sense. I'm surprised it worked correctly before 😄
As a separate task, we probably should consider whether it would be a good idea to stop publishing src folders to npm and copy PHP and JSON files to build folders for the block library.
|
Yeah, must have been a bug in webpack 4 that made it work before the upgrade. Makes sense to me to move the PHP and JSON files in npm. A bit odd that you have build folders but have to fetch some files from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Only ignore watch on files in the src folder that are handled by the build script.
This fixes a bug where
.jsonand.phpfiles in blocks isn't copied in development mode.Fixes #33993
How has this been tested?
See steps in issue
Screenshots
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).